Add status code to OTLP grpc trace log #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
approved these changes
Nov 23, 2022
marcalff
force-pushed
the
LogGrpcStatusCode
branch
from
af2a905 to
a9ba58a
Compare
|
Rebased on main, to resolve CI build failures. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1792 +/- ##
==========================================
+ Coverage 85.71% 85.79% +0.08%
==========================================
Files 171 171
Lines 5240 5240
==========================================
+ Hits 4491 4495 +4
+ Misses 749 745 -4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current OTLP grpc exporter logs
status_message()on failure which is insufficient for some cases like if the grpc service is not implemented in the server endpoint,status_message()outputs an empty string. Addsstatus_codein string format to give more information to the log. Following table shows the comparison.Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes